Do not pass "walltime=0" to span event #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `Event#getWallTime` returns `0`(default implementation), do not pass it to the underlying span event. Rather, let the span implementation determine the timestamp. Signed-off-by: Tadaya Tsuyukubo <[email protected]>
ttddyy
force-pushed
the
span-event-timestamp
branch
from
ac58a3b to
4b9b3a6
Compare
jonatan-ivanov
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #488
When
Event#getWallTimereturns0(default implementation), do not pass it to the underlying span event. Rather, let the span implementation determine the timestamp.