Add more tests for TimedHandler#6343
Merged
shakuzen merged 4 commits intomicrometer-metrics:1.13.xfrom Jun 5, 2025
Merged
Conversation
kwondh5217
force-pushed
the
main
branch
4 times, most recently
from
75e9a95 to
9533d63
Compare
shakuzen
requested changes
Jun 3, 2025
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Thank you for working on this. I left a review.
micrometer-jetty12/src/test/java/io/micrometer/jetty12/server/TimedHandlerTest.java
Outdated
Show resolved
Hide resolved
shakuzen
reviewed
Jun 3, 2025
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Thanks for the quick update. I've left another review.
micrometer-jetty12/src/test/java/io/micrometer/jetty12/server/TimedHandlerTest.java
Show resolved
Hide resolved
Contributor
Author
|
@shakuzen Thanks for the review! I updated the test to wait for the Please take another look when you have time 🙇 |
kwondh5217
force-pushed
the
main
branch
2 times, most recently
from
3be388c to
5e36e1a
Compare
shakuzen
approved these changes
Jun 5, 2025
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the pull request and all the quick updates in response to feedback. I'll rebase it on 1.13.x and merge forward from there.
…ts finish Closes micrometer-metricsgh-6227 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes micrometer-metricsgh-6227 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Closes micrometer-metricsgh-6227 Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Daeho Kwon <trewq231@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses gh-6227.
This test verifies that TimedHandler.shutdown() does not complete while any in-flight requests are still processing.
Specifically, it covers the following scenario:
Two requests (/a and /b) are initiated concurrently
TimedHandler.shutdown() is called while both are still in progress
One request (/b) completes
shutdownFuture should remain incomplete until the other request (/a) also completes
This test verifies the shutdown behavior using only the internal request/response flow, without externally calling shutdown.check(), in line with the discussion in #6194 (comment)