Fix darkness calculation in web interface#333
Closed
proski wants to merge 1 commit intomichaelrsweet:masterfrom
Closed
Fix darkness calculation in web interface#333proski wants to merge 1 commit intomichaelrsweet:masterfrom
proski wants to merge 1 commit intomichaelrsweet:masterfrom
Conversation
Round stored percent values to the closest hardware darkness value.
Owner
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
You can't just round the number in one place.
Contributor
Author
|
The original code would only preserve 0%, 20%, 40%, 60%, 80% and 100% for TSPL driver with 16 darkness levels. Other values would slide one step towards 0% on every save. |
Owner
|
OK, I've re-tested and agree. |
michaelrsweet
added
bug
michaelrsweet
added a commit
that referenced
this pull request
Feb 6, 2024
michaelrsweet
added a commit
that referenced
this pull request
Feb 6, 2024
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round stored percent values to the closest hardware darkness value.