replace resolver.query with resolver.resolve#19
Merged
michaelherold merged 3 commits intomichaelherold:masterfrom Dec 31, 2021
moshfrid:master
Merged
replace resolver.query with resolver.resolve#19michaelherold merged 3 commits intomichaelherold:masterfrom moshfrid:master
michaelherold merged 3 commits intomichaelherold:masterfrom
moshfrid:master
Conversation
Owner
|
Since they added this API in v2.0.0, we will need to bump the minimum version of the library. This also means we have to drop support for Python 2 (yay!), which necessitates a major version bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks so much for this great package. The dns.resolver.query function is deprecated https://github.com/rthalley/dnspython/blob/master/doc/whatsnew.rst#200 so this request is just aiming to replace it with the recommended dns.resolver.resolve.