chore(tests): consolidate redundant tests into table-driven patterns

Combine similar test functions into table-driven tests and remove
trivially redundant tests across 6 files. Net reduction of ~120 lines
while preserving all meaningful coverage.

Closes #138

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: cpcloud

internal/app/dashboard_rows_test.go

@@ -171,36 +171,45 @@ func TestDashExpiringRowsEmpty(t *testing.T) {
 // overhead
 // ---------------------------------------------------------------------------
 
-func TestOverheadSingleSection(t *testing.T) {
-	s := dashSection{title: "Projects", rows: make([]dashRow, 3)}
-	assert.Equal(t, 1, s.overhead())
-}
-
-func TestOverheadSubSections(t *testing.T) {
-	s := dashSection{
-		title:     "Maintenance",
-		subTitles: []string{"Overdue", "Upcoming"},
-		subCounts: []int{3, 2},
-	}
-	// 2 sub-headers + 1 blank separator = 3
-	assert.Equal(t, 3, s.overhead())
-}
-
-func TestOverheadSubSectionsOneEmpty(t *testing.T) {
-	s := dashSection{
-		title:     "Maintenance",
-		subTitles: []string{"Overdue", "Upcoming"},
-		subCounts: []int{3, 0},
+func TestOverhead(t *testing.T) {
+	tests := []struct {
+		name string
+		s    dashSection
+		want int
+	}{
+		{
+			"single section",
+			dashSection{title: "Projects", rows: make([]dashRow, 3)},
+			1,
+		},
+		{
+			"two non-empty sub-sections",
+			dashSection{
+				title: "Maintenance", subTitles: []string{"Overdue", "Upcoming"},
+				subCounts: []int{3, 2},
+			},
+			3, // 2 sub-headers + 1 blank separator
+		},
+		{
+			"one empty sub-section",
+			dashSection{
+				title: "Maintenance", subTitles: []string{"Overdue", "Upcoming"},
+				subCounts: []int{3, 0},
+			},
+			1,
+		},
+		{
+			"all sub-sections empty",
+			dashSection{
+				title: "Maintenance", subTitles: []string{"Overdue", "Upcoming"},
+				subCounts: []int{0, 0},
+			},
+			1,
+		},
 	}
-	// Only 1 non-empty sub-section -> overhead = 1.
-	assert.Equal(t, 1, s.overhead())
-}
-
-func TestOverheadAllSubSectionsEmpty(t *testing.T) {
-	s := dashSection{
-		title:     "Maintenance",
-		subTitles: []string{"Overdue", "Upcoming"},
-		subCounts: []int{0, 0},
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, tt.want, tt.s.overhead())
+		})
 	}
-	assert.Equal(t, 1, s.overhead())
 }

internal/app/dashboard_test.go

@@ -85,20 +85,15 @@ func TestDashboardToggle(t *testing.T) {
 	assert.False(t, m.showDashboard)
 }
 
-func TestDashboardDismissedByForward(t *testing.T) {
-	m := newTestModel()
-	m.showDashboard = true
-
-	sendKey(m, "f")
-	assert.False(t, m.showDashboard)
-}
-
-func TestDashboardDismissedByBack(t *testing.T) {
-	m := newTestModel()
-	m.showDashboard = true
-
-	sendKey(m, "b")
-	assert.False(t, m.showDashboard)
+func TestDashboardDismissedByTabSwitch(t *testing.T) {
+	for _, key := range []string{"f", "b"} {
+		t.Run(key, func(t *testing.T) {
+			m := newTestModel()
+			m.showDashboard = true
+			sendKey(m, key)
+			assert.False(t, m.showDashboard)
+		})
+	}
 }
 
 func TestDashboardNavigation(t *testing.T) {
@@ -293,18 +288,6 @@ func TestDashboardOverlay(t *testing.T) {
 	assert.Contains(t, ov, "help")
 }
 
-func TestDashboardOverlayComposite(t *testing.T) {
-	m := newTestModel()
-	m.width = 120
-	m.height = 40
-	m.showDashboard = true
-	m.dashboard = dashboardData{}
-	m.dashNav = nil
-
-	view := m.buildView()
-	assert.NotEmpty(t, view)
-}
-
 func TestDashboardOverlayFitsHeight(t *testing.T) {
 	m := newTestModel()
 	m.width = 80
@@ -743,12 +726,3 @@ func TestOverlayContentWidth(t *testing.T) {
 		})
 	}
 }
-
-func TestDashboardDefaultOnLaunchWithHouse(t *testing.T) {
-	m := newTestModel()
-	m.hasHouse = true
-	m.house = data.HouseProfile{Nickname: "Test"}
-	m.showDashboard = true
-
-	assert.True(t, m.showDashboard)
-}

internal/app/detail_test.go

@@ -216,11 +216,6 @@ func TestMaintenanceLogColumnReplacedManual(t *testing.T) {
 	}
 }
 
-func TestNewTestModelDetailNil(t *testing.T) {
-	m := newTestModel()
-	assert.Nil(t, m.detail())
-}
-
 func TestResizeTablesIncludesDetail(t *testing.T) {
 	m := newTestModel()
 	m.width = 120
@@ -321,13 +316,6 @@ func TestApplianceMaintenanceColumnSpecsNoAppliance(t *testing.T) {
 	assert.Equal(t, cellDrilldown, last.Kind)
 }
 
-func TestApplianceMaintColumnIsDrilldown(t *testing.T) {
-	specs := applianceColumnSpecs()
-	last := specs[len(specs)-1]
-	assert.Equal(t, "Maint", last.Title)
-	assert.Equal(t, cellDrilldown, last.Kind)
-}
-
 // ---------------------------------------------------------------------------
 // Drilldown stack tests
 // ---------------------------------------------------------------------------
@@ -514,23 +502,6 @@ func TestProjectColumnSpecsIncludeQuotes(t *testing.T) {
 	assert.Equal(t, cellDrilldown, last.Kind)
 }
 
-func TestVendorColumnsAreDrilldown(t *testing.T) {
-	specs := vendorColumnSpecs()
-	quotes := specs[6]
-	jobs := specs[7]
-	assert.Equal(t, "Quotes", quotes.Title)
-	assert.Equal(t, cellDrilldown, quotes.Kind)
-	assert.Equal(t, "Jobs", jobs.Title)
-	assert.Equal(t, cellDrilldown, jobs.Kind)
-}
-
-func TestApplianceMaintLogColumnIsDrilldown(t *testing.T) {
-	specs := applianceMaintenanceColumnSpecs()
-	last := specs[len(specs)-1]
-	assert.Equal(t, "Log", last.Title)
-	assert.Equal(t, cellDrilldown, last.Kind)
-}
-
 // ---------------------------------------------------------------------------
 // openDetailForRow dispatch tests
 // ---------------------------------------------------------------------------

internal/app/handler_crud_test.go

@@ -563,46 +563,25 @@ func TestMaintenanceHandlerSyncFixedValues(t *testing.T) {
 // Handler with non-existent IDs
 // ---------------------------------------------------------------------------
 
-func TestProjectHandlerSnapshotNonExistent(t *testing.T) {
+func TestHandlerSnapshotNonExistent(t *testing.T) {
 	m := newTestModelWithStore(t)
-	h := projectHandler{}
-	_, ok := h.Snapshot(m.store, 99999)
-	assert.False(t, ok)
-}
-
-func TestQuoteHandlerSnapshotNonExistent(t *testing.T) {
-	m := newTestModelWithStore(t)
-	h := quoteHandler{}
-	_, ok := h.Snapshot(m.store, 99999)
-	assert.False(t, ok)
-}
-
-func TestMaintenanceHandlerSnapshotNonExistent(t *testing.T) {
-	m := newTestModelWithStore(t)
-	h := maintenanceHandler{}
-	_, ok := h.Snapshot(m.store, 99999)
-	assert.False(t, ok)
-}
-
-func TestApplianceHandlerSnapshotNonExistent(t *testing.T) {
-	m := newTestModelWithStore(t)
-	h := applianceHandler{}
-	_, ok := h.Snapshot(m.store, 99999)
-	assert.False(t, ok)
-}
-
-func TestVendorHandlerSnapshotNonExistent(t *testing.T) {
-	m := newTestModelWithStore(t)
-	h := vendorHandler{}
-	_, ok := h.Snapshot(m.store, 99999)
-	assert.False(t, ok)
-}
-
-func TestServiceLogHandlerSnapshotNonExistent(t *testing.T) {
-	m := newTestModelWithStore(t)
-	h := serviceLogHandler{maintenanceItemID: 1}
-	_, ok := h.Snapshot(m.store, 99999)
-	assert.False(t, ok)
+	handlers := []struct {
+		name string
+		h    TabHandler
+	}{
+		{"project", projectHandler{}},
+		{"quote", quoteHandler{}},
+		{"maintenance", maintenanceHandler{}},
+		{"appliance", applianceHandler{}},
+		{"vendor", vendorHandler{}},
+		{"serviceLog", serviceLogHandler{maintenanceItemID: 1}},
+	}
+	for _, tc := range handlers {
+		t.Run(tc.name, func(t *testing.T) {
+			_, ok := tc.h.Snapshot(m.store, 99999)
+			assert.False(t, ok)
+		})
+	}
 }
 
 // ---------------------------------------------------------------------------

internal/app/handlers_test.go

@@ -42,14 +42,11 @@ func TestHandlerForFormKind(t *testing.T) {
 	}
 }
 
-func TestHandlerForFormKindHouseReturnsNil(t *testing.T) {
+func TestHandlerForFormKindReturnsNilForNonTabKinds(t *testing.T) {
 	m := newTestModel()
-	assert.Nil(t, m.handlerForFormKind(formHouse))
-}
-
-func TestHandlerForFormKindUnknownReturnsNil(t *testing.T) {
-	m := newTestModel()
-	assert.Nil(t, m.handlerForFormKind(formNone))
+	for _, kind := range []FormKind{formHouse, formNone} {
+		assert.Nilf(t, m.handlerForFormKind(kind), "expected nil handler for %v", kind)
+	}
 }
 
 func TestHandlerFormKindMatchesTabKind(t *testing.T) {