Skip to content

Add code fixer for MA0137 and MA0138 (async suffix naming)#1068

Merged
meziantou merged 4 commits intomainfrom
copilot/add-fixer-for-ma0137-and-ma0138
Mar 30, 2026
Merged

Add code fixer for MA0137 and MA0138 (async suffix naming)#1068
meziantou merged 4 commits intomainfrom
copilot/add-fixer-for-ma0137-and-ma0138

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026 •
edited
Loading

  • Create MethodsReturningAnAwaitableTypeMustHaveTheAsyncSuffixFixer.cs that handles MA0137 and MA0138 using Renamer.RenameSymbolAsync
  • Add code fix tests to MethodsReturningAnAwaitableTypeMustHaveTheAsyncSuffixAnalyzerTests.cs:
    • AsyncMethodWithoutSuffix_CodeFix_AddsAsyncSuffix (MA0137 regular method)
    • MethodNotReturningAwaitableTypeWithSuffix_CodeFix_RemovesAsyncSuffix (MA0138 regular method)
    • VoidLocalFunctionWithSuffix_CodeFix_RemovesAsyncSuffix (MA0138 local function)
  • Run dotnet run --project src/DocumentationGenerator to update markdown docs
  • Merge conflicts resolved with origin/main (MA0137 exclude_test_methods config option + new tests)
  • All 18 tests pass

Copilot AI changed the title [WIP] Add fixer for MA0137 and MA0138 using SymbolRenamer Add code fixer for MA0137 and MA0138 (async suffix naming) Mar 30, 2026
Copilot AI requested a review from meziantou March 30, 2026 14:18
meziantou
meziantou reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@meziantou meziantou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot There is no tests for one of the analyzer MethodsNotReturningAnAwaitableTypeMustNotHaveTheAsyncSuffix

@meziantou
Copy link
Copy Markdown
Owner

meziantou commented Mar 30, 2026

@copilot There are merge conflict, can you resolve them?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 30, 2026

@copilot There is no tests for one of the analyzer MethodsNotReturningAnAwaitableTypeMustNotHaveTheAsyncSuffix

Added VoidLocalFunctionWithSuffix_CodeFix_RemovesAsyncSuffix test covering the MA0138 local function code fix case in commit 772f415.

Copilot AI requested a review from meziantou March 30, 2026 14:39
@meziantou
Merge origin/main - resolve conflicts, keep code fix tests and exclud…
61ef050 
…e_test_methods config

Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 30, 2026

@copilot There are merge conflict, can you resolve them?

Merge conflicts resolved in 61ef050. The conflict in the test file was resolved by keeping both my code fix tests and the new exclude_test_methods configuration tests from main. All 18 tests pass.

@meziantou meziantou marked this pull request as ready for review March 30, 2026 14:56
@meziantou meziantou enabled auto-merge (squash) March 30, 2026 15:02
@meziantou meziantou merged commit 44d6c09 into main Mar 30, 2026
13 checks passed
@meziantou meziantou deleted the copilot/add-fixer-for-ma0137-and-ma0138 branch March 30, 2026 15:03
This was referenced Mar 30, 2026
Merged
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 4, 2026
Open
Open
Open
Merged
Open
Merged
Open
Merged
Open
Open
Merged
Open
Open
Merged
Merged
Merged
Merged
Merged
Open
Open
Open
Chris-Wolfgang added a commit to Chris-Wolfgang/DbContextBuilder that referenced this pull request Apr 6, 2026
@Chris-Wolfgang
Bump the dotnet-dependencies group with 2 updates (#158)
77546ef 
Updated [Azure.Identity](https://github.com/Azure/azure-sdk-for-net)
from 1.19.0 to 1.20.0.

<details>
<summary>Release notes</summary>

_Sourced from [Azure.Identity's
releases](https://github.com/Azure/azure-sdk-for-net/releases)._

## 1.20.0

## 1.20.0 (2026-03-30)

### Features Added

- Added a JSON schema segment to the NuGet package that provides
IntelliSense and validation for Azure.Identity credential configuration
in `appsettings.json`.

### Breaking Changes

- `AddAzureClient`, `AddKeyedAzureClient`, and `WithAzureCredential`
return type changed from `IHostApplicationBuilder` to `IClientBuilder`
to align with the `IClientBuilder` composition change in
System.ClientModel.


Commits viewable in [compare
view](Azure/azure-sdk-for-net@Azure.Identity_1.19.0...Azure.Identity_1.20.0).
</details>

Updated
[Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer)
from 3.0.29 to 3.0.44.

<details>
<summary>Release notes</summary>

_Sourced from [Meziantou.Analyzer's
releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._

## 3.0.44

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.44>

## What's Changed
* MA0011: suppress diagnostic when all AppendFormat template arguments
are culture-insensitive by @​Copilot in
meziantou/Meziantou.Analyzer#1085


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.43...3.0.44

## 3.0.43

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.43>

## What's Changed
* Fix expression parenthesis in code fixers by @​meziantou in
meziantou/Meziantou.Analyzer#1083


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.42...3.0.43

## 3.0.42

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.42>

## What's Changed
* Cache IsAwaitable result for the no-SyntaxNode overload by @​meziantou
in meziantou/Meziantou.Analyzer#1082


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.41...3.0.42

## 3.0.41

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.41>

## What's Changed
* Improve MA0042 async overload matching coverage by @​meziantou in
meziantou/Meziantou.Analyzer#1065


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.40...3.0.41

## 3.0.40

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.40>

## What's Changed
* Add MA0191: Detect null! and default! usage by @​Copilot in
meziantou/Meziantou.Analyzer#1081


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.39...3.0.40

## 3.0.39

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.39>

## What's Changed
* Add code fixes for MA0094-MA0097 by @​meziantou in
meziantou/Meziantou.Analyzer#1078


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.38...3.0.39

## 3.0.38

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.38>

## What's Changed
* Fix typos and grammar across all 188 rule documentation files by
@​Copilot in meziantou/Meziantou.Analyzer#1076
* Add code fixers for MA0118, MA0161, and MA0186 by @​meziantou in
meziantou/Meziantou.Analyzer#1079
* Validate fix conditions in RegisterCodeFixesAsync before registering
code fixes by @​Copilot in
meziantou/Meziantou.Analyzer#1077


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.37...3.0.38

## 3.0.37

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.37>

## What's Changed
* docs: require updating rule docs when rules change by @​meziantou in
meziantou/Meziantou.Analyzer#1075
* Add code fixers for MA0138/44/46/52/56/57/58/60/69/73 by @​meziantou
in meziantou/Meziantou.Analyzer#1074


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.36...3.0.37

## 3.0.36

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.36>

## What's Changed
* Add missing code fixers for 10 analyzer rules by @​meziantou in
meziantou/Meziantou.Analyzer#1073


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.35...3.0.36

## 3.0.35

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.35>

## What's Changed
* Add missing code fixers for MA0088-MA0137 by @​meziantou in
meziantou/Meziantou.Analyzer#1072


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.34...3.0.35

## 3.0.34

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.34>

## What's Changed
* Add code fixer for MA0174 (Record should use explicit 'class' keyword)
by @​Copilot in
meziantou/Meziantou.Analyzer#1070


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.33...3.0.34

## 3.0.33

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.33>

## What's Changed
* Add code fixer for MA0173 (Use LazyInitializer.EnsureInitialized) by
@​Copilot in meziantou/Meziantou.Analyzer#1071


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.32...3.0.33

## 3.0.32

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.32>

## What's Changed
* Add code fixer for MA0175 (Remove explicit `class` keyword from record
declarations) by @​Copilot in
meziantou/Meziantou.Analyzer#1069


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.31...3.0.32

## 3.0.31

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.31>

## What's Changed
* Add code fixer for MA0137 and MA0138 (async suffix naming) by
@​Copilot in meziantou/Meziantou.Analyzer#1068


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.30...3.0.31

## 3.0.30

NuGet package:
<https://www.nuget.org/packages/Meziantou.Analyzer/3.0.30>

## What's Changed
* MA0137: Add `exclude_test_methods` configuration option by @​Copilot
in meziantou/Meziantou.Analyzer#1067


**Full Changelog**:
meziantou/Meziantou.Analyzer@3.0.29...3.0.30

Commits viewable in [compare
view](meziantou/Meziantou.Analyzer@3.0.29...3.0.44).
</details>

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>
This was referenced Apr 6, 2026
Open
Open
Open
Open
Open
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@meziantou meziantou meziantou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@meziantou meziantou

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meziantou