Skip to content

Supported 204 No content#759

Merged
desandro merged 1 commit intometafizzy:masterfrom
icetee:master
Oct 5, 2018
Merged

Supported 204 No content#759
desandro merged 1 commit intometafizzy:masterfrom
icetee:master

Conversation

@icetee
Copy link
Copy Markdown
Contributor

@icetee icetee commented Jan 17, 2018

Server can send 204 HTTP code. This indicates there is no more content.
https://httpstatuses.com/204

Server can send 204 HTTP code. This indicates there is no more content.
https://httpstatuses.com/204
@desandro
Copy link
Copy Markdown
Member

Thank you for this contribution. This seems very straight forward. Before I merge, I'll have to update documentation to mention this new feature. I'll keep this open until then.

@desandro desandro self-assigned this Jan 25, 2018
@zackkatz
Copy link
Copy Markdown

This would be great to have merged. Thanks, @icetee!

@Enalmada
Copy link
Copy Markdown

I was just going to open a ticket asking for this same thing. It seems like infinite-scroll is crashing on 204 right now which makes this a very desirable merge. Thanks @desandro!

@desandro desandro merged commit ddab0fe into metafizzy:master Oct 5, 2018
@desandro
Copy link
Copy Markdown
Member

desandro commented Oct 5, 2018

This PR has been merged and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants