More robust handling of incompatible layout files #507
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if conf.remoteDebuggingPort.isSome: | ||
| electronArgs.add("--remote-debugging-port=" & conf.remoteDebuggingPort.get) | ||
|
|
||
| wrapElectron(electronArgs, appArgs) |
There was a problem hiding this comment.
Electron debug flags duplicated in command line arguments
In eventuallyWrapElectron, appArgs is populated with ALL raw command line arguments via paramStr(i), which includes --inspect and --remote-debugging-port flags injected by Playwright. These same flags are then also extracted from the parsed conf and added to electronArgs. When wrapElectron(electronArgs, appArgs) is called, the flags appear twice in the final electron command—once before and once after the entry point. This differs from the StartupCommand.electron case which correctly uses conf.electronAppArgs with the restOfArgs pragma to exclude parsed options.
| warnPrint "Could not copy default layout, reading bundled default directly" | ||
| let (bundledData, bundledErr) = await fsreadFileWithErr(cstring(fmt"{configDir / defaultLayoutPath}")) | ||
| if bundledErr.isNil: | ||
| return JSON.parse(bundledData) |
There was a problem hiding this comment.
Unhandled JSON parse exceptions in reset function
The JSON.parse calls in resetLayoutToDefault (lines 270 and 276) are not wrapped in try/except. When this function is called from inside an except block in loadLayoutConfig or loadEditLayoutConfig, any parse exception would propagate up unhandled instead of reaching the intended quit(1) with the "critical - cannot load any layout config" error message. This undermines the PR's goal of robust error handling if the bundled default layout is somehow corrupted.
Note
Adds validation and auto-reset for corrupted/incompatible layout JSON, forwards Playwright
--inspect/--remote-debugging-portto Electron, and introduces layout resilience tests.isValidLayoutConfigand auto-reset to bundled default withresetLayoutToDefaultwhen corrupt/incompatible.loadLayoutConfig/loadEditLayoutConfigwith parse/structure checks and recovery; addfsUnlinkWithErrbridge inhelpers.tsand bindings.inspectandremote-debugging-port;eventuallyWrapElectron(conf)now forwards these to Electron.wrapElectron(electronArgs, appArgs)(posix) and adapt electron command to useelectronAppArgs.CatchableErrorin Nim entrypoints.tsc-ui-tests/tests/layout/layout_resilience.spec.tsand C# UI testsLayoutResilienceTestswith registry entries, plus cleaner env setup inct_helpers.ts.Written by Cursor Bugbot for commit 2426f92. This will update automatically on new commits. Configure here.