Add LICENSE file #395
Add LICENSE file #395
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for torchtune-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
msaroufim
left a comment
msaroufim
left a comment
There was a problem hiding this comment.
Sorry what does this license mean exactly? It doesn't seem like it's quite the Llama license but something else?
| @@ -0,0 +1,11 @@ | |||
| Copyright 2024 Meta | |||
There was a problem hiding this comment.
It should be more obvious when looking at the file that this is BSD-3
| Copyright 2024 Meta | |
| BSD 3-Clause License | |
| Copyright 2024 Meta |
There was a problem hiding this comment.
Ah @NicolasHug thanks so much! I actually was curious about this as well. I dug through fast gpt for example (https://github.com/pytorch-labs/gpt-fast?tab=BSD-3-Clause-1-ov-file) and didn'f see this in the raw file. I'm sure I'm missing something simple. What is it?
There was a problem hiding this comment.
GitHub can figure it out itself even if it's not explicit mentioned, but I see no reason not to include it for those who are reading this file outside of the GH UI.
All of audio, vision, text and rl make it explicit:
https://github.com/pytorch/vision/blob/main/LICENSE
https://github.com/pytorch/audio/blob/main/LICENSE
https://github.com/pytorch/text/blob/main/LICENSE
https://github.com/pytorch/rl/blob/main/LICENSE
There was a problem hiding this comment.
Ok that makes sense to me. Yup no reason to not make this explicit. Will update before merging.
|
@msaroufim this is BSD3, it just doesn't say it is |
when setting `enable_memory_snapshot = true` in `.toml` * dump memory snapshots in case of OOMs. output folder is `memory_snapshot/iteration_x_exit` * dump regularly according to `profile_freq`. output folder is `memory_snapshot/iteration_x` * existing `.toml` works since `enable_memory_snapshot=False` by default snapshot is an example of the dump when OOM happens <img width="1640" alt="Screenshot 2024-06-12 at 9 26 53 PM" src="https://github.com/pytorch/torchtitan/assets/134637289/6420799c-ae68-4b35-b8bb-f5b6ab3dd053">
Context
Changelog
Test plan