check if log_dir is not none #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2389
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a679bc4 with merge base d5d85c5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
joecummings
reviewed
Feb 12, 2025
torchtune/training/metric_logging.py
Outdated
|
|
||
| # create log_dir if missing | ||
| if not os.path.exists(self.log_dir): | ||
| if self.log_dir and not os.path.exists(self.log_dir): |
Member
There was a problem hiding this comment.
A new test would be nice ...
Contributor
Author
There was a problem hiding this comment.
if self.log_dir works, no? Did you suggest "is not None" for readability or something else?
boooo for the test
Member
There was a problem hiding this comment.
If there's a possibility it can be None, then the proper check is if x is not None
Member
There was a problem hiding this comment.
I'm fine with filing a follow up for test :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
if log_dir was not passed ,it would crash. This makes log_dir optonal
Test plan
Before this change:
After this change:
It works!