[Bug Fix]Disable DSD for saving ckpt #2346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2346
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
acisseJZhong
requested review from
ebsmothers,
felipemello1,
joecummings and
mori360
and removed request for
ebsmothers and
joecummings
felipemello1
reviewed
Feb 5, 2025
Contributor
felipemello1
left a comment
felipemello1
left a comment
There was a problem hiding this comment.
@acisseJZhong , if its not too painful, can you confirm that it also works for meta ckpt?
torchtune/training/_distributed.py
Outdated
| cpu_state_dict[param_name] = param.cpu() | ||
| torch.distributed.barrier() | ||
| return cpu_state_dict | ||
| # TODO: Fix issues with DSD before uncommenting the following code. See #2313 and #2277. |
Contributor
There was a problem hiding this comment.
this is ugly, but i guess thats what Evan requested. Can you confirm @ebsmothers ?
Contributor
There was a problem hiding this comment.
Oh sorry I don't want to have the commented-out code. Can we just go back to the version of these functions prior to #2138? I think the TODO is fine though
Contributor
Author
|
Verified it works with Meta checkpoint! |
felipemello1
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
*
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_testUX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example