-
Notifications
You must be signed in to change notification settings - Fork 693
[doc][modules] update to modules documentation #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1079
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 539ad06 with merge base dceaf05 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
joecummings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits, mostly looks good.
joecummings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Felipe Mello <[email protected]>
Context
What is the purpose of this PR? Is it to
Changelog
Test plan
make html- confirmed it rendered wellpre-commit install)pytest testspytest tests -m integration_test