Guide contributions#2
Merged
Merged
Conversation
aganders3
force-pushed
the
guide-suggestions
branch
from
46a9b1f to
91dca53
Compare
aganders3
force-pushed
the
guide-suggestions
branch
from
7f9b2fd to
4625758
Compare
Author
|
I added a draft of the project layout section, mostly taken from the current readme but including some information on adding type hints. |
messense
approved these changes
Nov 2, 2021
Owner
|
Thanks |
Owner
|
I’m gonna move the branch to the main repository so we can coordinate there. (I missed the notification somehow with this repo). |
messense
added a commit
that referenced
this pull request
Apr 6, 2026
- Fix #1 (critical): prepend_to now defers patches to finish_internal(), avoiding "Generated file was already added" crash when __init__.py patching happens before source files are collected - Fix #2 (high): Python patches are now inserted after 'from __future__' imports via find_python_insertion_point() to avoid SyntaxError - Fix #3 (high): add_new_section_with_names now errors on non-Authenticode overlays instead of silently truncating them - Fix #4 (medium): When PE section headers are full, shift sections down by FileAlignment bytes (matching delvewheel) instead of bailing - Fix #5 (medium): is_python_dll now precisely matches CPython (python[0-9]+t?(_d)?.dll) and PyPy (libpypy*-c.dll) patterns - Expand KNOWN_SYSTEM_DLLS from ~60 to ~90 entries covering crypto, networking, UI, and storage subsystems commonly linked by native extensions
messense
added a commit
that referenced
this pull request
Apr 7, 2026
- Fix #1 (critical): prepend_to now defers patches to finish_internal(), avoiding "Generated file was already added" crash when __init__.py patching happens before source files are collected - Fix #2 (high): Python patches are now inserted after 'from __future__' imports via find_python_insertion_point() to avoid SyntaxError - Fix #3 (high): add_new_section_with_names now errors on non-Authenticode overlays instead of silently truncating them - Fix #4 (medium): When PE section headers are full, shift sections down by FileAlignment bytes (matching delvewheel) instead of bailing - Fix #5 (medium): is_python_dll now precisely matches CPython (python[0-9]+t?(_d)?.dll) and PyPy (libpypy*-c.dll) patterns - Expand KNOWN_SYSTEM_DLLS from ~60 to ~90 entries covering crypto, networking, UI, and storage subsystems commonly linked by native extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now this is a first draft of a tutorial. I can add to this PR if I get more time to work on other sections. Actually helping write the guide seems like a great way to get more familiar with the project.
For the tutorial it might make sense to include the source in an examples folder, but at the same time there are several great examples in the pyo3 project already. I was tempted to use one of those but I started from scratch to make sure I didn't miss any steps.
Of course there are others with way more experience, so I welcome any and all feedback and critique!