Skip to content

[Bug]; Orca Whirlpool; Fix cumulativeUniqueUsers Logic #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bug]; Orca Whirlpool; Fix cumulativeUniqueUsers Logic #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions orca-whirlpool/src/modules/21_store_cumulative_users.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use substreams::pb::substreams::store_delta::Operation;
use substreams::pb::substreams::Clock;
use substreams::skip_empty_output;
use substreams::store::{DeltaBigInt, Deltas, StoreAddInt64, StoreDelete};
Expand All @@ -20,16 +21,22 @@ pub fn store_cumulative_users(
0,
&StoreKey::UsageMetricsDailySnapshot(day_id - 1, None).unique_id(),
);
for delta in unique_users_delta.deltas {
let key = delta.get_key();

for _ in unique_users_delta.deltas {
store.add_many(
0,
&vec![
StoreKey::CumulativeUsers.unique_id(),
if key.starts_with(&StoreKey::User.unique_id())
&& delta.get_operation() == Operation::Create
{
// Add to cumulative users
store.add(0, StoreKey::CumulativeUsers.unique_id(), 1);
} else {
// Add to daily active users
store.add(
0,
StoreKey::UsageMetricsDailySnapshot(day_id, Some(Box::new(StoreKey::ActiveUsers)))
.get_snapshot_key(None),
],
1,
);
1,
);
}
}
}