add support for mesos maintenance primitives #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fsero
approved these changes
Jun 16, 2017
ivanilves
approved these changes
Jun 16, 2017
alanbover
approved these changes
Jun 19, 2017
zmalik
force-pushed
the
master
branch
2 times, most recently
from
e24f915 to
8de3fc8
Compare
vixns
added a commit
to vixns/chronos
that referenced
this pull request
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the #829 this PR adds support for the maintenance primitives.
What it provides:
Fail-safe scaling down of the mesos cluster, without a single job failing. With the help of tools like https://github.com/alanbover/deathnode
We are already using this feature in our production. And I think can be quite interest of chronos community to have it. In order to scale up&down of mesos cluster with 0 jobs failed/killed