Skip to content

sanity_checks: add tip about using old format #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meator
Copy link
Contributor

@meator meator commented Aug 13, 2025

I spent a lot of time trying to follow this error message's advice to run tools/format.py without success. It took me a while to figure out that newer versions of Meson modified its formatting rules, so a file that was correctly formatted with Meson 1.6.1 (to give an example) will be considered unformatted by Meson 1.9.0rc2 (or whatever the runners use now). 1.6.1 isn't even that old.

The wording may need to be changed, this PR is more of a proposal.

@bgilbert
Copy link
Collaborator

Perhaps format.py should install the latest Meson release into a virtualenv and run it from there, either always or only if the system's Meson is too old.

@bgilbert
Copy link
Collaborator

#2325 changes format.py to run Meson from a virtualenv it maintains with the latest prerelease.

@meator
Copy link
Contributor Author

meator commented Aug 20, 2025

Wow, thanks @bgilbert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants