Fix IntrospectionInterpreter._add_languages to allow simplifying compiler options #14507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
added
refactoring
bonzini
force-pushed
the
intro-compiler-options
branch
from
61b833e to
a3788ca
Compare
bonzini
force-pushed
the
intro-compiler-options
branch
3 times, most recently
from
969400a to
9667001
Compare
bruchar1
approved these changes
Apr 29, 2025
bonzini
force-pushed
the
intro-compiler-options
branch
from
9667001 to
eefdb85
Compare
Let add_compiler_options and process_compiler_options handle subprojects, and also run it for the main project to ensure that pending_options are properly processed. This exposes a bug because "comp" could have been None, so fix that. Signed-off-by: Paolo Bonzini <[email protected]>
The subproject and machine should already be correct, thanks to form_compileropt_key. Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
intro-compiler-options
branch
from
eefdb85 to
b129859
Compare
dcbaker
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #14498