rust: pass global and project C args to clang in bindgen #12283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/bindgen-project-global-args
branch
2 times, most recently
from
d00ca36 to
b0066ad
Compare
tristan957
approved these changes
Sep 25, 2023
Member
|
Should this be a 1.3 PR instead? |
dcbaker
force-pushed
the
submit/bindgen-project-global-args
branch
from
b0066ad to
c301ccb
Compare
Member
Author
|
@tristan957 Not sure, the original issue was tagged for 1.2.2 so I tagged the commit as well. I did just realize we should also be considering |
This means that arguments set via `add_global_arguments`, `add_project_arguments` and by either the `-Dc_args` or `CFLAGS` are applied to bindgen as well. This can be important when, among other things, #defines are set via these mechanisms. Fixes: mesonbuild#12065
dcbaker
force-pushed
the
submit/bindgen-project-global-args
branch
from
c301ccb to
e6dd580
Compare
tristan957
approved these changes
Sep 25, 2023
Member
|
I'll let you make the decision on how you want to target it. But LGTM |
Member
Author
|
I'll leave it on 1.2.2, we can always move it to 1.3.0 if there is objection to merging it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that any arguments given project wide or globally (such as preprocessor defines) will be set.
Fixes: #12065