Update environment.py

[CorrodedCoder]

Solaris 5.10 uname doesn't support the -o switch, and illumos started with version 5.11 so shortcut the logic to report 'solaris' in such cases where the version is 5.10 or below.

[eli-schwartz]

Thanks. The changes look good but the commit message could use a bit of tweaking to describe what is being solved in the first line. "Update ${filename}" isn't very descriptive :( and makes it difficult to locate a commit by viewing the git log or even the web UI at https://github.com/mesonbuild/meson/commits/master

(This is the same problem as the PR title, by the way.)

[CorrodedCoder]

Yes, my bad - I'm not particularly used to contributing to GitHub projects other than my own and I was just intending to show my change rather than actually submitting it.
I don't mind if someone else would like to submit the change themselves, or if you'd rather I try to improve the situation I will attempt it, but you may need to baby sit me a little.

[eli-schwartz]

Command line instructions:

1. Make sure you have a git clone of your forked PR. git clone it if you have to, then "git checkout" the PR branch.

2. Then you can simply use git commit --amend, and it will offer you the existing commit message (the most recent commit on that branch, specifically) to edit and fix up.

3. git push -f to update the PR.

[dcbaker]

@CorrodedCoder This looks good from a code point of view. If you could update the commit message, I'd like to merge this for inclusion in the next point release.

[CorrodedCoder]

I'm using GitHub Desktop but I think I was able to follow the instructions Eli suggested. Please feel free to let me know if I misunderstood.

[dcbaker]

Looks good to me. Thanks!

[eli-schwartz]

Thank you! I haven't used GitHub Desktop myself (so I can't give instructions for it) but whatever you did there seems to be exactly what I suggested anyway, so that's all good. :)

[eli-schwartz]

Meh. The github web UI sucks for review.

I looked at this with git log, and for future reference, commit messages should ideally be reflowed to ~80 character long lines, but this was not.

Not quite the end of the world, sure...