-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Wrap: Use git instead of patch by default #12248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This solves problems with Strawberry Perl providing patch.exe on Windows with an unconsistent line ending support. Fixes: mesonbuild#12092
|
s/unconsistent/inconsistent |
Do you think this PR should tackle this comment too? I think we already do something for pkg-config? |
|
meson/mesonbuild/dependencies/pkgconfig.py Line 216 in d2dfef5
|
|
Looks not possible to discover this given the discussion in the issue thread. |
|
I think it's not limited to Perl, there are different patch implementation and it depends how they deal with line ending. I think using git gives us a least something consistent across all platforms. |
dvrogozh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should improve applying patches to submodules which is one of key features of meson. Suggest to merge.
patch.exe is available from multiple origins which proves to have inconsistent behavior due to patches applied on top (or not applied) during build of the application. Like MSYS is well patched, but original patch.exe is not. See #12092 for details.
Since the pip version uses outdated version of meson where diff_files is broken See mesonbuild/meson#12092 and mesonbuild/meson#12248
Since the pip version uses outdated version of meson where diff_files is broken See mesonbuild/meson#12092 and mesonbuild/meson#12248
Since the pip version uses outdated version of meson where diff_files is broken See mesonbuild/meson#12092 and mesonbuild/meson#12248
Since the pip version uses outdated version of meson where diff_files is broken See mesonbuild/meson#12092 and mesonbuild/meson#12248
Since the pip version uses outdated version of meson where diff_files is broken See mesonbuild/meson#12092 and mesonbuild/meson#12248
Since the pip version uses outdated version of meson where diff_files is broken See mesonbuild/meson#12092 and mesonbuild/meson#12248
This solves problems with Strawberry Perl providing patch.exe on Windows with an unconsistent line ending support.
Fixes: #12092