Fix assertion raised with invalid option name #12231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-schwartz
reviewed
Sep 7, 2023
bruchar1
force-pushed
the
get-option-invalid-key
branch
from
b151f33 to
24bcd2f
Compare
When a unittest introspect a meson.build file from a test case, the file may contain a testcase block. We should ignore this block.
bruchar1
force-pushed
the
get-option-invalid-key
branch
from
24bcd2f to
fb8d644
Compare
nirbheek
reviewed
Sep 12, 2023
bruchar1
force-pushed
the
get-option-invalid-key
branch
3 times, most recently
from
e4ce495 to
c186ab7
Compare
When option name contains more that one dot, it should be detected earlier to prevent an assert to be raised. Fixes mesonbuild#11904.
bruchar1
force-pushed
the
get-option-invalid-key
branch
from
c186ab7 to
5e81a2a
Compare
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When option name contains more that one dot, it should be detected earlier to prevent an assert to be raised.
Fixes #11904.