-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix bug with openssl when cmake is missing #12226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug with openssl when cmake is missing #12226
Conversation
|
Do you think we can test this in CI or not? |
I'm not sure it would be easy. I requires openssl to be not available, and cmake neither. |
|
Maybe try searching with |
I succeed writing a testcase that triggers the bug on the master branch, by using a native file with a dummy cmake path. But... in the fix branch, it triggers a DependencyException from dependencies/cmake.py:127 |
5275851 to
a5c39a5
Compare
|
Ok, I think I succeed writing it as a unittest. |
|
Maybe it should be in platform agnostic tests instead? |
Fixes mesonbuild#12098 DependencyFactory was returning a lambda, but it has no log_tried() function
a5c39a5 to
de123ed
Compare
Yes. I wasn't sure where to put it. Moved. |
|
Fixes #11145 |
|
A fix was previously proposed in #11147. |
Fixes #12098
Fixes #11145
DependencyFactory was returning a lambda, but it has no log_tried() function.