Skip to content

Conversation

@bruchar1
Copy link
Member

@bruchar1 bruchar1 commented Sep 6, 2023

Fixes #12098
Fixes #11145

DependencyFactory was returning a lambda, but it has no log_tried() function.

@bruchar1 bruchar1 requested a review from jpakkane as a code owner September 6, 2023 19:53
@tristan957
Copy link
Member

Do you think we can test this in CI or not?

@tristan957 tristan957 added this to the 1.3.0 milestone Sep 6, 2023
@bruchar1
Copy link
Member Author

bruchar1 commented Sep 7, 2023

Do you think we can test this in CI or not?

I'm not sure it would be easy. I requires openssl to be not available, and cmake neither.

@eli-schwartz
Copy link
Member

Maybe try searching with method: 'cmake' plus whatever cmake settings are necessary to make it think it can't find openssl, e.g.searching only in self.builddir.

@bruchar1
Copy link
Member Author

bruchar1 commented Sep 7, 2023

Maybe try searching with method: 'cmake' plus whatever cmake settings are necessary to make it think it can't find openssl, e.g.searching only in self.builddir.

I succeed writing a testcase that triggers the bug on the master branch, by using a native file with a dummy cmake path. But... in the fix branch, it triggers a DependencyException from dependencies/cmake.py:127

@bruchar1 bruchar1 force-pushed the openssl-cmake-not-found-bug branch from 5275851 to a5c39a5 Compare September 7, 2023 13:01
@bruchar1
Copy link
Member Author

bruchar1 commented Sep 7, 2023

Ok, I think I succeed writing it as a unittest.

@eli-schwartz
Copy link
Member

Maybe it should be in platform agnostic tests instead?

Fixes mesonbuild#12098

DependencyFactory was returning a lambda, but it has no log_tried() function
@bruchar1 bruchar1 force-pushed the openssl-cmake-not-found-bug branch from a5c39a5 to de123ed Compare September 7, 2023 13:32
@bruchar1
Copy link
Member Author

bruchar1 commented Sep 7, 2023

Maybe it should be in platform agnostic tests instead?

Yes. I wasn't sure where to put it. Moved.

@bruchar1
Copy link
Member Author

bruchar1 commented Sep 7, 2023

Fixes #11145

@bruchar1
Copy link
Member Author

bruchar1 commented Sep 7, 2023

A fix was previously proposed in #11147.

@nirbheek nirbheek merged commit 57178e8 into mesonbuild:master Sep 12, 2023
@nirbheek nirbheek modified the milestones: 1.3.0, 1.2.2 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled python exception problem with dependency('openssl')

5 participants