Skip to content

Conversation

@eli-schwartz
Copy link
Member

/cc @xclaesse

@eli-schwartz eli-schwartz requested a review from jpakkane as a code owner August 31, 2023 17:05
@eli-schwartz
Copy link
Member Author

@xclaesse
Copy link
Member

I like it a lot, looks much better thanks!

While at it, something I've always wanted to change is tests that fails because there are unexepected installed files, the list of files is not printed in the summary of failed tests, you have to scroll all the way up to when it ran the test.

@jpakkane
Copy link
Member

Looking nice. Would it be possible to make the Python unittest thingy output the brief dot format? Having a ton of lines like these is not very informative:

 unittests/machinefiletests.py::NativeFileTests::test_builtin_options_subprojects_overrides_buildfiles 
[gw1] [ 90%] PASSED unittests/machinefiletests.py::NativeFileTests::test_builtin_options_subprojects_overrides_buildfiles 

@eli-schwartz
Copy link
Member Author

While at it, something I've always wanted to change is tests that fails because there are unexepected installed files, the list of files is not printed in the summary of failed tests, you have to scroll all the way up to when it ran the test.

Implemented in 71f5a12

Example log: https://github.com/eli-schwartz/meson/actions/runs/6042585162/job/16397982654#step:8:2447

List each testcase name that failed so we can see at a glance which ones
they are.
Logs for failing tests come first, then the list of pass/fail.
It is fairly confusing for all the "ninja explain" to be the last thing
you see, instead of the compile error.
Make sure this is generic enough to be properly usable
@xclaesse
Copy link
Member

xclaesse commented Sep 1, 2023

LGTM, nice work!

@jpakkane
Copy link
Member

jpakkane commented Sep 1, 2023

FWICT Pytest still prints the long format for succeeding tests:

 unittests/platformagnostictests.py::PlatformAgnosticTests::test_setup_loaded_modules 
[gw0] [ 86%] SKIPPED unittests/platformagnostictests.py::PlatformAgnosticTests::test_setup_loaded_modules 

@eli-schwartz eli-schwartz merged commit 156a9ba into mesonbuild:master Sep 1, 2023
@eli-schwartz eli-schwartz deleted the project_tests_logging branch September 1, 2023 21:19
@jpakkane
Copy link
Member

jpakkane commented Sep 1, 2023

It's not mandatory, so ok to merge, but I feel it would improve readability.

@eli-schwartz
Copy link
Member Author

Changing that would have been an additional commit, but I haven't yet looked at what, if anything, it is doing there.

@nirbheek nirbheek added this to the 1.2.2 milestone Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants