-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CI: improve project tests logging #12188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: improve project tests logging #12188
Conversation
|
I like it a lot, looks much better thanks! While at it, something I've always wanted to change is tests that fails because there are unexepected installed files, the list of files is not printed in the summary of failed tests, you have to scroll all the way up to when it ran the test. |
|
Looking nice. Would it be possible to make the Python unittest thingy output the brief dot format? Having a ton of lines like these is not very informative: |
Implemented in 71f5a12 Example log: https://github.com/eli-schwartz/meson/actions/runs/6042585162/job/16397982654#step:8:2447 |
List each testcase name that failed so we can see at a glance which ones they are.
Logs for failing tests come first, then the list of pass/fail.
It is fairly confusing for all the "ninja explain" to be the last thing you see, instead of the compile error.
Make sure this is generic enough to be properly usable
2603c89 to
156a9ba
Compare
|
LGTM, nice work! |
|
FWICT Pytest still prints the long format for succeeding tests: |
|
It's not mandatory, so ok to merge, but I feel it would improve readability. |
|
Changing that would have been an additional commit, but I haven't yet looked at what, if anything, it is doing there. |
/cc @xclaesse