Ensure vswhere output is captured in utf8 #11778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruchar1
force-pushed
the
vsenv-utf8-encoding
branch
2 times, most recently
from
43d719c to
fbf843c
Compare
Member
eli-schwartz
left a comment
eli-schwartz
left a comment
There was a problem hiding this comment.
This sounds like #10799?
bruchar1
force-pushed
the
vsenv-utf8-encoding
branch
from
fbf843c to
56609b6
Compare
Member
|
Is there anything left in this PR? Does it need to be closed? Otherwise it seems pretty innocuous. |
Member
|
I think this PR still makes sense, but I'm not sure what's the expected encoding of environment variables printed in BAT script on Windows. Wondering if it should be |
Member
Author
Or |
Member
Author
|
FIxed by #12088. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11770