ZlibSystemDependency: pass libtype to clib_compiler.find_library

[alanc]

Makes it stop reporting that it found a static zlib on Solaris which does not ship a static library file for libz, and thus allows "test cases/rust/13 external c dependencies" to pass.

Fixes #10906

On Solaris 11.4.57, this changes the results of that rust test case from:

 [SUCCESS]   rust: 13 external c dependencies    (static=False method=cmake)
 [SUCCESS]   rust: 13 external c dependencies    (static=False method=pkg-config)
 [SUCCESS]   rust: 13 external c dependencies    (static=False method=system)
 [SUCCESS]   rust: 13 external c dependencies    (static=True method=cmake)
  [ERROR]    rust: 13 external c dependencies    (static=True method=system)
During: build
Reason: Compiling source code failed.

to

 [SUCCESS]   rust: 13 external c dependencies    (static=False method=cmake)
 [SUCCESS]   rust: 13 external c dependencies    (static=False method=pkg-config)
 [SUCCESS]   rust: 13 external c dependencies    (static=False method=system)
 [SUCCESS]   rust: 13 external c dependencies    (static=True method=cmake)
 [SKIPPED]   rust: 13 external c dependencies    (static=True method=system)
Reason: Could not find a static zlib

[eli-schwartz]

@dcbaker Do you have any idea what is up with the rust link errors this PR is causing? I'm completely confused here.

[dcbaker]

I can't reproduce the failure locally, so I'm wondering if it's been fixed in the mean time (also the logs are gone). I've rebased this on main, so let's see how it looks now

[eli-schwartz]

Unfortunately the error is still there, but now you can see it in the logs. :)

[dcbaker]

Oh boy, that's a legit bug that exists right now. We don't proper propogate the links out to the rust targets from external deps. You can replicate this by installing only a static zlib and using any dependency method.

[dcbaker]

Oh, and it gets better. Sigh

[dcbaker]

I've added a patch that will hopefully fix this (it fixes my system at least). I think both of these deserve a backport, but if someone things the zlib one doesn't we can merge that separately so it can be backported

[eli-schwartz]

I'm happy to backport them both, unless someone else objects.

[xclaesse]

Hm, CI started to fail in master after this PR, any chance it's related? https://github.com/mesonbuild/meson/actions/runs/6276237334/job/17045465367

[eli-schwartz]

I cannot see how it would be related, and it passed in this PR itself.

[xclaesse]

yeah, seems completely unrelated to all our changes tbh.

[eli-schwartz]

It is most likely because homebrew updated to LLVM 17, cf. @carlocab

Probably, meson has issues detecting LLVM 17 in all cases and we are simply seeing the errors on homebrew first.

[eli-schwartz]

Ah, apparently it was fixed by adding 17 to the names of possible llvm-config programs. Yay!