typo in internal shared libraries docs? ERROR: Got unknown keyword arguments "install_path"

[AndrewAnnex]

I am struggling with a seemingly common issue of bundling a shared library (for a pure c library I build via a subproject) in my python wheel (#765, #673, #410) .

While trying to follow the example at, https://mesonbuild.com/meson-python/how-to-guides/shared-libraries.html I get the following error ERROR: Got unknown keyword arguments "install_path" from meson when attempting to set that variable for the shared_library.

According to the meson docs, shared_library only accepts install_dir (https://mesonbuild.com/Reference-manual_functions.html#shared_library_install_dir)

Likely this line will need to be updated:

meson-python/docs/how-to-guides/shared-libraries.rst

Line 71 in 7efa417

install_path: py.get_install_dir() / 'mypkg/subdir'

I want to confirm that my interpretation of a typo in the docs was correct or if install_path is meant to be used elsewhere and not with the shared_library.

[eli-schwartz]

It is a typo. Meson doesn't support "install_path" anywhere. The only references to the term are internal python implementation details such as storage attributes e.g. for the joined repr of install_dir + target file basename. Which isn't relevant to the meson.build DSL.

[AndrewAnnex]

okay good to know. @eli-schwartz I can submit a tiny pr for that if desired. I will open a separate issue/discussion for the bigger problem I was mentioning

[eli-schwartz]

Sure, that makes sense to me (although I mainly stick to working on meson itself, not the "mesonpy" backend, so I don't want to speak authoritatively for this repo even though I am technically a Member).

[rgommers]

Indeed a typo, my bad - should have been install_dir. A PR with a fix is very welcome @AndrewAnnex. Or I can do it if you prefer.

[AndrewAnnex]

@rgommers #771 is up for review