Null vlan parameter in cisco.meraki.networks_switch_qos_rules_order module unsupported

[jennban]

In the documentation it mentions being able to set the value of the "vlan" parameter to "null" in order to create a QoS rule that will match any source VLAN. When attempting to run the play shown below with the vlan parameter set to None or null I get the following results. FWIW setting vlan to None in the python SDK works as intended.

None Value

null Value

[fmunozmiranda]

Hi @jennban please try it with new version and update us.

[jennban]

Hi @fmunozmiranda assigning the vlan a null value now works as expected, a new bug has been introduced it seems though now. When running a playbook to create multiple rules the dashboard only has the last rule that was ran in the playbook. It likes like the previous plays get overwritten with the last play that gets ran. The plays from the screenshot below will replicate the problem described above.

[fmunozmiranda]

could you please try it again with new version? @jennban

[jennban]

Hey @fmunozmiranda getting closer. most rules create new objects when they try and get configured. Some of them however don't create new objects, two rules below.

I was looking through the code and it doesn't look like you're comparing all the parameters (srcPortRange and dstPortRange) to determine if the rule is "new" or not.

dashboard-api-ansible/plugins/action/networks_switch_qos_rules_order.py

Lines 166 to 172 in 93dfc56

	for item in items:
	if (item.get("vlan") == self.new_object.get("vlan") and
	item.get("protocol") == self.new_object.get("protocol") and
	item.get("srcPort") == self.new_object.get("srcPort") and
	item.get("dstPort") == self.new_object.get("dstPort")):
	result = item
	break

[fmunozmiranda]

In last version we included it. Please try it again. @jennban

[jennban]

this looks to be fixed based on my testing. Thanks!