This repository was archived by the owner on Jul 4, 2025. It is now read-only.
chore: enable create file test for all platforms #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
changed the title
vansangpfiev
added a commit
that referenced
this pull request
Mar 27, 2025
) * fix: std::filesystem::equivalent does not work for non-exist path * chore: enable create file test for all platforms (#2183) --------- Co-authored-by: sangjanai <[email protected]>
3 tasks
vansangpfiev
added a commit
that referenced
this pull request
Mar 27, 2025
) * fix: std::filesystem::equivalent does not work for non-exist path * chore: enable create file test for all platforms (#2183) --------- Co-authored-by: sangjanai <[email protected]>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes a change to the
engine/e2e-test/api/files/test_api_create_file.pyfile. The change involves removing apytest.mark.skipifdecorator from thetest_api_create_file_successfullymethod, which previously skipped the test on non-Linux platforms.Testing improvements:
engine/e2e-test/api/files/test_api_create_file.py: Removed thepytest.mark.skipifdecorator that skipped thetest_api_create_file_successfullytest on non-Linux platforms, indicating an intention to fix the test for Mac and Windows platforms in the future.Fixes Issues
Self Checklist