Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

chore: small refactor for /models/pull #2144

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

chore: small refactor for /models/pull #2144

wants to merge 8 commits into from

Conversation

gau-nernst
Copy link
Contributor

@gau-nernst gau-nernst commented Mar 18, 2025 •
edited
Loading

Describe Your Changes

  • Move model pull logic from controller to service
  • Thanks to the above, we can make DownloadModelFromCortexsoAsync() and HandleDownloadUrlAsync() private methods
  • Add test for /models/pull with author_id:model_id:GGUF_filename format.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@gau-nernst gau-nernst requested a review from vansangpfiev March 18, 2025 10:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

Preview URL: https://f9ad937d.cortex-docs.pages.dev

@gau-nernst gau-nernst requested a review from vansangpfiev March 19, 2025 05:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vansangpfiev vansangpfiev Awaiting requested review from vansangpfiev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gau-nernst @vansangpfiev