This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: logger issue #1858
Merged
fix: logger issue #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhoangthuan99
approved these changes
Jan 15, 2025
vansangpfiev
added a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: vansangpfiev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes a change to the
FileLoggerclass to modify the file opening mode in theOpenFilemethod. The most important change is as follows:engine/utils/file_logger.cc: Changed the file opening mode from "r+" (read/update) to "a+" (append/update) in theFileLogger::CircularLogFile::OpenFilemethod. This ensures that the file pointer is positioned at the end of the file for writing, and it creates the file if it does not exist.Fixes Issues
Self Checklist