Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: add cpu_threads to model.yaml #1845

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: add cpu_threads to model.yaml #1845

merged 1 commit into from
Jan 13, 2025

Conversation

vansangpfiev
Copy link
Contributor

This pull request introduces a new configuration parameter, cpu_threads, to various parts of the codebase, and refactors the writeKeyValue method to WriteKeyValue for consistency. The most important changes include updates to the ModelConfig structure, YAML handling, and test cases.

New Configuration Parameter cpu_threads:

Refactoring writeKeyValue to WriteKeyValue:

Test Case Updates:

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review January 8, 2025 02:19
Copy link
Contributor

@nguyenhoangthuan99 nguyenhoangthuan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vansangpfiev vansangpfiev merged commit c508e68 into dev Jan 13, 2025
11 checks passed
@vansangpfiev vansangpfiev deleted the fix/cpu-threads branch January 13, 2025 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants