Skip to content

Add Error Handling for JSON body parsing #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Add Error Handling for JSON body parsing #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21bcdc7
Add error handling for JSON.parse
domwebber Oct 17, 2024
33314c1
Add invalid JSON body test case
domwebber Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,11 @@ app.all('*', (req, res) => {

//If the Content-Type of the incoming body `is` JSON, it can be parsed and returned in the body
if(req.is('application/json')){
echo.json = JSON.parse(req.body)
try {
echo.json = JSON.parse(req.body)
} catch (error) {
console.warn("Invalid JSON Body received with Content-Type: application/json", error);
}
}

//If there's a JWT header, parse it and decode and put it in the response
Expand Down
9 changes: 9 additions & 0 deletions tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,15 @@ else
exit 1
fi

REQUEST=$(curl -s -X POST -H "Content-Type: application/json" -d 'not-json' http://localhost:8080)
if [ $(echo $REQUEST | jq -r '.json') == 'null' ]; then
passed "JSON with Invalid Body test passed."
else
failed "JSON with Invalid Body test failed."
echo $REQUEST | jq
exit 1
fi

message " Stop containers "
docker stop http-echo-tests
sleep 5
Expand Down