Skip to content

Adapt script to update macro version #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Adapt script to update macro version #685

merged 2 commits into from
Jul 15, 2025

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jul 15, 2025

Following merge of this PR

#682

Summary by CodeRabbit

  • Chores
    • Updated the process for managing macro dependency versions, so only the macro's own version is updated automatically, while the main dependency declaration remains unchanged.
    • Simplified version tag checks during release validation by removing redundant comparisons and related error messages.

@curquiza curquiza requested a review from Mubelotix July 15, 2025 17:54
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jul 15, 2025
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025

Walkthrough

The update_macro_versions.sh script was modified to remove the step that updates the meilisearch-index-setting-macro dependency version in the main Cargo.toml file. Now, the script only updates the version in meilisearch-index-setting-macro/Cargo.toml, leaving the main dependency declaration unchanged. Additionally, .github/scripts/check-release.sh was changed by removing the extraction and comparison of a secondary version tag and its related error message.

Changes

File Change Summary
scripts/update_macro_versions.sh Removed logic updating macro version in main Cargo.toml; now only updates meilisearch-index-setting-macro/Cargo.toml.
.github/scripts/check-release.sh Removed extraction and comparison of a secondary version tag and its associated error message.

Poem

A script once hopped through every file,
Updating versions with diligent style.
But now it skips the main Cargo’s line,
And leaves the macro’s version to shine.
With lighter steps and simpler cheer,
The rabbit’s work is now more clear!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1794e71 and d75acf4.

📒 Files selected for processing (1)
  • .github/scripts/check-release.sh (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/scripts/check-release.sh
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: integration-tests
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (7021789) to head (d75acf4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
- Coverage   85.76%   85.69%   -0.07%     
==========================================
  Files          19       19              
  Lines        5860     5860              
==========================================
- Hits         5026     5022       -4     
- Misses        834      838       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@curquiza
Copy link
Member Author

bors merge

Copy link
Contributor

meili-bors bot commented Jul 15, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit fbb7807 into main Jul 15, 2025
10 of 11 checks passed
@meili-bors meili-bors bot deleted the curquiza-patch-1 branch July 15, 2025 18:20
Mubelotix added a commit that referenced this pull request Jul 16, 2025
This reverts commit fbb7807, reversing
changes made to f9f4e53.
@coderabbitai coderabbitai bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants