Fix deleted_tasks field type in TaskDeletion struct #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mubelotix
approved these changes
Jul 11, 2025
Mubelotix
added
the
breaking-change
Merged
meili-bors bot
added a commit
that referenced
this pull request
Jul 15, 2025
682: Merge dev into main r=curquiza a=Mubelotix Full changelog after this PR: (includes changes merged before this PR) ## What's Changed ### Breaking changes * Fix deleted_tasks field type in TaskDeletion struct by `@coinmoles` in #666 (`TaskDeletion.deleted_tasks` and `TaskCancelation.canceled_tasks` have been made `Option`s) ### Enhancements * Support all experimental features by `@ellnix` in #656 * Add `usedDatabaseSize` to stats by `@Alirexaa` in #653 * Add facet_search API functionality by `@hmacr` in #512 * Allow users to customize facet value sort behaviour by `@hmacr` in #514 * Support `embedders` setting and other vector/hybrid search related configuration by `@CommanderStorm` in #554 * Add documents and embbedings database metrics to stats response by `@Alirexaa` in #652 * Support facet search and prefix search settings by `@ellnix` in #634 * Serialize for MultiSearchResponse by `@milesgranger` in #668 * Implement federated multi search by `@LukasKalbertodt` in #625 * Add support for similar docs query by `@JiaYingZhang` in #674 ### Maintainance * Remove _md code samples for Mintlify migration by `@curquiza` in #661 * Add missing `exist` to `*_update` functions' docs by `@funlennysub` in #617 * Add Code Coverage GH action by `@Alirexaa` in #654 ## New Contributors * `@Alirexaa` made their first contribution in #653 * `@funlennysub` made their first contribution in #617 * `@milesgranger` made their first contribution in #668 * `@coinmoles` made their first contribution in #666 * `@JiaYingZhang` made their first contribution in #674 **Full Changelog**: v0.28.0...v0.29.0 Co-authored-by: hmacr <[email protected]> Co-authored-by: Clémentine U. - curqui <[email protected]> Co-authored-by: Frank Elsinga <[email protected]> Co-authored-by: Clémentine <[email protected]> Co-authored-by: Vladimir Donich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #665
What does this PR do?
deleted_tasksfield inTaskDeletionfromusizetoOption<usize>Option<usize>since it can be null according to the API documentationPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!