Skip to content

Fix wasm panic when trying to change the user-agent #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

bidoubiwa
Copy link
Contributor

Fixes: #308

User-agent can not be changed in chromium. It is considered a security breach. Probably because of that wasm does not accept it either.

@bidoubiwa bidoubiwa added the bug Something isn't working label Aug 31, 2022
@bidoubiwa bidoubiwa requested a review from brunoocasali August 31, 2022 14:41
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 7, 2022

Build succeeded:

@bors bors bot merged commit 2689764 into main Sep 7, 2022
@bors bors bot deleted the fix_user_agent_panic_in_wasm branch September 7, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panics during search with a 'Headers' error
2 participants