Disable code-cov #913
Merged
Disable code-cov #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanders41
added
the
skip-changelog
curquiza
added
maintenance
curquiza
reviewed
Jan 15, 2024
.github/workflows/tests.yml
Outdated
Comment on lines
39
to
44
| # - name: Upload coverage | ||
| # uses: codecov/codecov-action@v3 | ||
| # with: | ||
| # fail_ci_if_error: true | ||
| # env: | ||
| # CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Suggested change
| # - name: Upload coverage | |
| # uses: codecov/codecov-action@v3 | |
| # with: | |
| # fail_ci_if_error: true | |
| # env: | |
| # CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
I would go with completely remove them, and mention in the PR in the issue we will open to say we want something else than code coverage
sanders41
commented
Jan 15, 2024
Comment on lines
+112
to
+122
| "hits": [ | ||
| { | ||
| "id": 1, | ||
| "title": "Carol", | ||
| "genre": ["Romance", "Drama"] | ||
| } | ||
| ], | ||
| "offset": 0, | ||
| "limit": 20, | ||
| "processingTimeMs": 1, | ||
| "query": "caorl" |
There was a problem hiding this comment.
My editor seems to have auto-formatted some of these places in the readme when I saved. If you want me to disable my auto-formatting and resave I can do that.
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!