Migrate docs to Meilisearch subdomain #810
Conversation
Strift
changed the title
|
I realize my initial description of the issue was a bit light. I updated it. |
There was a problem hiding this comment.
LGTM
The goal of this PR is to prepare the repository to have the docs migrated to https://python-sdk.meilisearch.com
Does preparing mean you want to hold this for now or merge?
| @@ -0,0 +1 @@ | |||
| python-sdk.meilisearch.com/ | |||
There was a problem hiding this comment.
One thing I just though of, wouldn't the CNAME file go in the docs folder instead of the root directory?
There was a problem hiding this comment.
From my understanding of the Github docs, it should be at the root of the repository.
There was a problem hiding this comment.
I'm an no expert here, but I think that assumes the purpose of the repo is for docs only. You can see how I have it setup here and working https://github.com/sanders41/meilisearch-python-async/tree/main/docs. Though like I said I'm not an expert so maybe my setup works, but isn't correct.
There was a problem hiding this comment.
I'll go ahead and merge. The worst thing I can think that would happen is the CNAME doesn't get picked up and then we just need a new PR to move the file.
|
No reason to hold this for now. The changes shouldn't have any effect until we update DNS configuration for the Meilisearch domain. But I can't guarantee when this will be done (although today or in the coming days is likely.) When that is effective, I will make another small PR to update the links to the SDK docs in the README. The current docs URL will still be working so it's OK if we're not 100% synchronous on this. If it all looks good to you, I'm happy to merge this. Thanks for your help! |
|
@Strift looks like the redirect is happening, but I am getting an error that the site can't be reached at the new subdomain. |
|
Ok I found it. The pages settings have been updated. @bwklein if you have any specific questions while this gets sorted out and want to ask in either an issue on on Discord I'll do my best to help. |
I'll find you on Discord. We updated some things and now we are getting an unexpected error through the Python SDK. |
|
bors merge |
|
Build succeeded:
|
|
@sanders41 I'm not sure really. Seems weird that the changes to Pages settings would result in this downtime. It didn't happen when we did the same change on meilisearch-php repository. I asked @alallema @tpayet to help me check if it could be due to DNS settings, as I don't have access. |
sanders41
added
the
skip-changelog
815: Update version for the next release (v0.28.2) r=sanders41 a=meili-bot This version introduces features released on Meilisearch v1.3.0 🎉 Check out the changelog of [Meilisearch v1.3.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.3.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ## 🚀 Enhancements *⚠️ **EXPERIMENTAL**: Adds docstring and tests for vector search (#805) `@sanders41`⚠️ The EXPERIMENTAL features are not covered by semver. To explicitly opt-in, check this [guide](https://www.meilisearch.com/docs/reference/api/experimental-features). ## 🐛 Bug Fixes * Fix potential json_encoding date error and truncation in pydantic < 2 (#807) `@sanders41` ## 💅 Misc * Migrate docs hosting to Meilisearch subdomain (#810) `@Strift` * Update documentation deployment workflow (#811) `@Strift` Thanks again to `@Strift,` `@alallema,` and `@sanders41!` 🎉 Co-authored-by: meili-bot <[email protected]>
Pull Request
The goal of this PR is to prepare the repository to have the docs migrated to
https://python-sdk.meilisearch.com.What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!