Skip to content

Conversation

Strift
Copy link
Contributor

@Strift Strift commented Apr 30, 2025

Pull Request

Related issue

Error running publishing job: https://github.com/meilisearch/meilisearch-dart/actions/runs/14748878787

Error
reusable workflows should be referenced at the top-level `jobs.*.uses' key, not within steps

What does this PR do?

  • Reference the workflow at the job.*.uses key level
  • Separate the "check release" in a different job

Thank you so much for contributing to Meilisearch!

@Strift Strift requested review from curquiza and Copilot April 30, 2025 07:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the publishing workflow by referencing the reusable workflow at the job level and moving the release validation into a separate job.

  • Introduces a new job named "check_release" to handle release validity.
  • Updates the "publishing" job to depend on "check_release" and correctly reference the reusable workflow.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Apr 30, 2025

Build succeeded:

@Strift Strift merged commit 8088dac into main Apr 30, 2025
6 checks passed
@Strift Strift deleted the chore/fix-publishing branch April 30, 2025 07:30
@Strift Strift added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants