Skip to content

Conversation

@haoel
Copy link
Contributor

@haoel haoel commented Apr 27, 2023

No description provided.

@haoel haoel requested review from localvar and samanhappy April 27, 2023 09:29
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.19 ⚠️

Comparison is base (caaf586) 99.68% compared to head (476796f) 99.49%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   99.68%   99.49%   -0.19%     
==========================================
  Files          83       80       -3     
  Lines        5643     5590      -53     
==========================================
- Hits         5625     5562      -63     
- Misses         12       22      +10     
  Partials        6        6              
Impacted Files Coverage Δ
global/global.go 100.00% <ø> (ø)
conf/conf.go 97.06% <100.00%> (+0.33%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samanhappy
Copy link
Collaborator

There is a error log during restarting, is it expected?
ERRO[2023-04-27T18:11:38+08:00] [Web] HTTP server error: accept tcp [::]:8181: use of closed network connection

@haoel
Copy link
Contributor Author

haoel commented Apr 27, 2023

There is a error log during restarting, is it expected? ERRO[2023-04-27T18:11:38+08:00] [Web] HTTP server error: accept tcp [::]:8181: use of closed network connection

if this message is appeared around the following message, it should be fine

INFO[2023-04-27T19:01:49+08:00] !!! RECEIVED THE SIGTERM EXIT SIGNAL, EXITING... !!! 
ERRO[2023-04-27T19:01:49+08:00] [Web] HTTP server error: accept tcp 127.0.0.1:8181: use of closed network connection 
INFO[2023-04-27T19:01:49+08:00] [Web] HTTP server is shutdown  

@haoel
Copy link
Contributor Author

haoel commented Apr 28, 2023

@samanhappy I use the http.Server.Shutdown() instead the Close(), and deal with the error ErrServerClosed , I think this time I use the correct way to shutdown the HTTP Server.

@haoel haoel added this pull request to the merge queue Apr 28, 2023
Merged via the queue into megaease:main with commit 8704e05 Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants