Add remark-mdx-remove-esm to list of plugins#2675
Open
talatkuyuk wants to merge 1 commit intomdx-js:mainfrom
Open
Add remark-mdx-remove-esm to list of plugins#2675talatkuyuk wants to merge 1 commit intomdx-js:mainfrom
remark-mdx-remove-esm to list of plugins#2675talatkuyuk wants to merge 1 commit intomdx-js:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2649 2649
Branches 2 2
=========================================
Hits 2649 2649 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
remcohaszing
approved these changes
Apr 2, 2026
Member
remcohaszing
left a comment
There was a problem hiding this comment.
Thanks!
I have some small tips, but it looks mostly good.
- Instead of exposing the
clsxutility, you could accept falsy values inMdxRemoveEsmOptions. But really I would leave this up to the user. - You can use the
mdxlanguage for the code fence in the readme instead ofmarkdown. - In
tsconfig.jsonyou specifyincludeas a glob ("src/**/*"). You can also specify a directory ("src"). It’s the same, but in my experience allowing glob patterns can grow and become unmanageable. - Your tests aren’t type checked.
Contributor
Author
|
Thanks @remcohaszing for the suggestions which all I agreed with. It is done, including the removal of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
remark-mdx-remove-esm is a remark plugin that removes import and/or export statements (mdxjsEsm) from MDX content. It provides an essential security layer for applications handling user-generated content.
It is a remark plugin to sanitize MDX content by removing ESM (
import/export) statements for enhanced security.This change adds
remark-mdx-remove-esmto the plugin list in the docs.