-
Notifications
You must be signed in to change notification settings - Fork 23k
chore(ia): Reorganize CSS pages - part 6 (moving keywords, types, functions under reference/values) #41810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| --- | ||
| title: <color> | ||
| slug: Web/CSS/color_value | ||
| slug: Web/CSS/Reference/Values/color_value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you would want to remove _value here?
|
I know we already reached "agreement" on this so not a blocker (though it's because I didn't really put much thought into it at first), but is there a reason to put functions, keywords, and types in the same folder? Types are not code entities in CSS but functions and keywords are, and to me the difference is extremely unambiguous, so I would have separated |
|
I am in favor of keeping the relationships intact in the filesystem. So we're keeping:
And similarly, The relationship between About dropping the |
pepelsbey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you :)
I think this sidebar will be a good compromise until we have a better system.
|
Thanks for reviewing 🙌 |
See the proposed structure at css-tree-proposed.json.
Steps performed
Created the
css/reference/valuesdirectory and a listing page for "Values". (files/en-us/web/css/reference/values/index.md).Moved these pages into
css/reference/values:page-type: css-keywordpage-type: css-typeand their child directories (e.g.,basic-shape/circle)page-type: css-functions(not already insidevalues,properties, orat-rules)Moved the existing
css_values_and_units/css_value_functionsdirectory under and ascss/reference/values/functions.Moved the existing
css_values_and_units/css_data_typesdirectory under and ascss/reference/values/data_types.Updated the sidebar (
files/sidebars/cssref.yaml):File structure before and after
Current structure:
After the move:
Related pull requests
Related issues
Discussion: https://github.com/orgs/mdn/discussions/256
Tracker issue: mdn/mdn#662