Skip to content

added the mdn_urls now those pages have been added #27612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

added the mdn_urls now those pages have been added #27612

wants to merge 1 commit into from

Conversation

dletorey
Copy link
Contributor

Summary

  • Added the mdn_url for:
    • :heading
    • :heading()

Related issues

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:xs [PR only] 0-6 LoC changed labels Aug 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

caugner
caugner reviewed Aug 19, 2025
View reviewed changes
css/selectors/headingfunction.json
@@ -4,6 +4,7 @@
"headingfunction": {
"__compat": {
"description": "`:heading()`",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/:heading",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct page should be https://developer.mozilla.org/en-US/docs/Web/CSS/:heading_function, and that one has no BCD table yet, and therefore no BCD frontmatter.

css/selectors/heading.json
@@ -4,6 +4,7 @@
"heading": {
"__compat": {
"description": "`:heading`",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/:heading",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile added by #27618.

@caugner
Copy link
Contributor

caugner commented Aug 19, 2025

@dletorey Please note that we have automation that adds mdn_urls when the MDN page references BCD key, so manually adding mdn_urls is generally discouraged. (We should maybe make this explicit somewhere in the README or docs.)

Once you add BCD frontmatter to the :heading_function page, it will automatically be added to BCD data within the next day or so. 😉

So I'm going to close this PR.

@caugner caugner closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner left review comments

Assignees
No one assigned
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:xs [PR only] 0-6 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dletorey @caugner