Skip to content

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 14, 2024

Summary

data were taken from AbortSignal.abort() static method reason parameter, and in fact it is a part of this feature

chrome data confirmed by chromium/chromium@155b235 and https://issues.chromium.org/issues/40202936 (#16956)

deno data confirmed by https://docs.deno.com/api/web/~/AbortController.abort and denoland/deno#12697 (#13380)

firefox data confirmed by mozilla/gecko-dev@712c0d5 and https://bugzilla.mozilla.org/show_bug.cgi?id=1737771 (#14418)

nodejs data confirmed by https://nodejs.org/docs/latest/api/globals.html#abortcontrollerabortreason and nodejs/node#40807 (#17418)

safari data confirmed by WebKit/WebKit@d354a8d and https://bugs.webkit.org/show_bug.cgi?id=232299 (#16956)

Test results and supporting details

Related issues

Fixes #24899

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 14, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 14, 2024 09:10
@caugner caugner changed the title Fixes #24899 | Add AbortController.abort() reason Add AbortController.abort() parameter reason Nov 15, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified the referenced sources for Chrome, Deno, Firefox, Node.js, and Safari.

@caugner caugner merged commit e9b14c4 into mdn:main Nov 15, 2024
5 checks passed
@skyclouds2001 skyclouds2001 deleted the abortcontroller-abort-reason branch November 15, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing data for AbortController.abort() reason argument
2 participants