Skip to content

Making key decryption nicer #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

de-nordic
Copy link
Collaborator

No description provided.

Signed-off-by: Dominik Ermel <[email protected]>
@de-nordic de-nordic requested a review from davidvincze as a code owner June 17, 2025 19:56
@de-nordic de-nordic force-pushed the why-do-i-even-care branch from d38f851 to 49ac2fd Compare June 18, 2025 08:04
@de-nordic de-nordic force-pushed the why-do-i-even-care branch from 49ac2fd to 46b5b6a Compare June 18, 2025 08:20
Copy link
Collaborator

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st and 3rd commits LGTM

#endif
#if !defined(MCUBOOT_ENCRYPT_KW)
uint8_t *cp;
uint8_t *cpend;
size_t len;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code which is using depends on #if defined(MCUBOOT_ENCRYPT_RSA)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have converted it to draft, because this is unfinished. I have accidentally pushed it as non-draft.

@de-nordic de-nordic marked this pull request as draft June 25, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants