boot: Remove image_index from boot_encrypt #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
replace-index-with-slot-in-boot_encrypt
branch
from
951af8d to
5a23327
Compare
3 tasks
nvlsianpu
approved these changes
Jul 25, 2024
|
@de-nordic Conflict, |
de-nordic
force-pushed
the
replace-index-with-slot-in-boot_encrypt
branch
2 times, most recently
from
a0fb0b2 to
bde2d36
Compare
|
@de-nordic failure on (ram-load enc-aes256-kw multiimage |
de-nordic
force-pushed
the
replace-index-with-slot-in-boot_encrypt
branch
from
bde2d36 to
ce66835
Compare
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Jul 26, 2024
boot_encrypt required the image_index paired with flash area pointer to be able to figure out which slot it will operate on. Since in most calls the slot is known in advance it can be just passed to the function directly. The commit replaces both parameters with slot number. Upstream PR: mcu-tools/mcuboot#2013 Signed-off-by: Dominik Ermel <[email protected]>
davidvincze
requested changes
Jul 30, 2024
boot_encrypt required the image_index paired with flash area pointer to be able to figure out which slot it will operate on. Since in most calls the slot is known in advance it can be just passed to the function directly. The commit replaces both parameters with slot number. Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
replace-index-with-slot-in-boot_encrypt
branch
from
ce66835 to
3d098ae
Compare
davidvincze
approved these changes
Jul 31, 2024
|
@davidvincze Got some glitch in github where your ack appeared as request for changes. |
davidvincze
approved these changes
Aug 1, 2024
I hope it's okay now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boot_encrypt required the image_index paired with flash area pointer to be able to figure out which slot it will operate on. Since in most calls the slot is known in advance it can be just passed to the function directly.
The commit replaces both parameters with slot number.