Skip to content

boot: Remove image_index from boot_encrypt #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

de-nordic
Copy link
Collaborator

boot_encrypt required the image_index paired with flash area pointer to be able to figure out which slot it will operate on. Since in most calls the slot is known in advance it can be just passed to the function directly.
The commit replaces both parameters with slot number.

@de-nordic de-nordic force-pushed the replace-index-with-slot-in-boot_encrypt branch from 951af8d to 5a23327 Compare July 18, 2024 13:51
@de-nordic de-nordic marked this pull request as ready for review July 24, 2024 11:44
@de-nordic de-nordic requested a review from nvlsianpu July 24, 2024 11:44
@de-nordic de-nordic added the crypto Encryption support label Jul 24, 2024
@nvlsianpu
Copy link
Collaborator

@de-nordic Conflict,

@de-nordic de-nordic force-pushed the replace-index-with-slot-in-boot_encrypt branch 2 times, most recently from a0fb0b2 to bde2d36 Compare July 26, 2024 10:22
@nvlsianpu
Copy link
Collaborator

@de-nordic failure on (ram-load enc-aes256-kw multiimage

@de-nordic de-nordic force-pushed the replace-index-with-slot-in-boot_encrypt branch from bde2d36 to ce66835 Compare July 26, 2024 15:36
de-nordic added a commit to de-nordic/sdk-mcuboot that referenced this pull request Jul 26, 2024
boot_encrypt required the image_index paired with flash area pointer
to be able to figure out which slot it will operate on.
Since in most calls the slot is known in advance it can be just
passed to the function directly.
The commit replaces both parameters with slot number.

Upstream PR: mcu-tools/mcuboot#2013

Signed-off-by: Dominik Ermel <[email protected]>
boot_encrypt required the image_index paired with flash area pointer
to be able to figure out which slot it will operate on.
Since in most calls the slot is known in advance it can be just
passed to the function directly.
The commit replaces both parameters with slot number.

Signed-off-by: Dominik Ermel <[email protected]>
@de-nordic de-nordic force-pushed the replace-index-with-slot-in-boot_encrypt branch from ce66835 to 3d098ae Compare July 31, 2024 15:41
@de-nordic de-nordic requested a review from davidvincze July 31, 2024 16:15
@de-nordic de-nordic requested a review from davidvincze August 1, 2024 06:23
@de-nordic
Copy link
Collaborator Author

@davidvincze Got some glitch in github where your ack appeared as request for changes.

@davidvincze
Copy link
Collaborator

@davidvincze Got some glitch in github where your ack appeared as request for changes.

I hope it's okay now :)

@davidvincze davidvincze merged commit 3f11286 into mcu-tools:main Aug 1, 2024
58 checks passed
@de-nordic de-nordic deleted the replace-index-with-slot-in-boot_encrypt branch October 10, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Encryption support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants