zephyr: Add missing Kconfig dependencies for USB DFU #1652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
added a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Mar 17, 2023
USB DFU depends on MULTITHREADING and STREAM_FLASH, and these should be explicitly selected. Upstream PR: mcu-tools/mcuboot#1652 (cherry picked from commit 14d4ed63ea3543aeb7ece7c8814b56ff9b6219ea) Signed-off-by: Dominik Ermel <[email protected]>
nordicjm
requested changes
Mar 17, 2023
boot/zephyr/Kconfig
Outdated
| @@ -419,6 +419,8 @@ config BOOT_USB_DFU_WAIT | |||
| select USB_DEVICE_STACK | |||
| select USB_DFU_CLASS | |||
| select IMG_MANAGER | |||
| select STREMA_FLASH | |||
There was a problem hiding this comment.
"Eh. I will make some experiments with this and I can always type those things back, those are just four lines, what can go wrong"... that is how I get these kinds of bugs.
USB DFU depends on MULTITHREADING and STREAM_FLASH, and these should be explicitly selected. Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
fix-usb-dfu-kconfig
branch
from
14d4ed6 to
8b0debc
Compare
de-nordic
added a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Mar 17, 2023
USB DFU depends on MULTITHREADING and STREAM_FLASH, and these should be explicitly selected. Upstream PR: mcu-tools/mcuboot#1652 (cherry picked from commit 8b0debce3932dd1afbb1c509708bdde07f930b73) Signed-off-by: Dominik Ermel <[email protected]>
nordicjm
approved these changes
Mar 17, 2023
utzig
approved these changes
Mar 17, 2023
de-nordic
added a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Mar 27, 2023
USB DFU depends on MULTITHREADING and STREAM_FLASH, and these should be explicitly selected. Upstream PR: mcu-tools/mcuboot#1652 (cherry picked from commit 8b0debce3932dd1afbb1c509708bdde07f930b73) Signed-off-by: Dominik Ermel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USB DFU depends on MULTITHREADING and STREAM_FLASH, and these should be explicitly selected.