Skip to content

boot_serial: Fix rc not being returned as a signed value #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

nordicjm
Copy link
Collaborator

@nordicjm nordicjm commented Dec 2, 2022

Fixes an issue whereby rc is a signed variable but is returned as an unsigned variable in the zcbor functions.

Fixes #1537

Fixes an issue whereby rc is a signed variable but is returned as
an unsigned variable in the zcbor functions.

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm
Copy link
Collaborator Author

nordicjm commented Dec 2, 2022

@de-nordic @nvlsianpu

nordicjm added a commit to nordicjm/sdk-mcuboot that referenced this pull request Dec 2, 2022
Fixes an issue whereby rc is a signed variable but is returned as
an unsigned variable in the zcbor functions.

Upstream PR: mcu-tools/mcuboot#1538

Signed-off-by: Jamie McCrae <[email protected]>
@de-nordic de-nordic requested review from nvlsianpu and d3zd3z December 2, 2022 09:33
nordicjm added a commit to nrfconnect/sdk-mcuboot that referenced this pull request Dec 2, 2022
Fixes an issue whereby rc is a signed variable but is returned as
an unsigned variable in the zcbor functions.

Upstream PR: mcu-tools/mcuboot#1538

Signed-off-by: Jamie McCrae <[email protected]>
@nvlsianpu nvlsianpu merged commit 0b6d343 into mcu-tools:main Dec 2, 2022
nordicjm added a commit to nordicjm/sdk-mcuboot that referenced this pull request Dec 6, 2022
Fixes an issue whereby rc is a signed variable but is returned as
an unsigned variable in the zcbor functions.

Upstream PR: mcu-tools/mcuboot#1538

Signed-off-by: Jamie McCrae <[email protected]>
(cherry picked from commit 78fd7ff)
mbolivar-nordic pushed a commit to mbolivar-nordic/sdk-mcuboot that referenced this pull request Feb 20, 2023
Fixes an issue whereby rc is a signed variable but is returned as
an unsigned variable in the zcbor functions.

Upstream PR: mcu-tools/mcuboot#1538

Signed-off-by: Jamie McCrae <[email protected]>
(cherry picked from commit 78fd7ff)
@nordicjm nordicjm deleted the serial_rc_fix branch December 12, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serial recovery returns rc as an unsigned value
3 participants