serial recovery: Add unaligned stack buffer writing #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
requested changes
Dec 1, 2022
nordicjm
force-pushed
the
serial_flash_fix
branch
from
b42987f to
46bf7e8
Compare
nordicjm
requested review from
de-nordic
and removed request for
d3zd3z and
nvlsianpu
de-nordic
approved these changes
Dec 1, 2022
nordicjm
added a commit
to nordicjm/sdk-mcuboot
that referenced
this pull request
Dec 1, 2022
Fixes a bug when writing to devices which have memory alignment requirements with data being using directly from a zcbor-response whereby the alignment of the buffer data does not meet the requirements of the flash driver. Upstream PR: mcu-tools/mcuboot#1533 Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
added a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Dec 2, 2022
Fixes a bug when writing to devices which have memory alignment requirements with data being using directly from a zcbor-response whereby the alignment of the buffer data does not meet the requirements of the flash driver. Upstream PR: mcu-tools/mcuboot#1533 Signed-off-by: Jamie McCrae <[email protected]>
nvlsianpu
requested changes
Dec 5, 2022
nvlsianpu
changed the title
nordicjm
force-pushed
the
serial_flash_fix
branch
from
46bf7e8 to
10d7b79
Compare
Fixes a bug when writing to devices which have memory alignment requirements with data being using directly from a zcbor-response whereby the alignment of the buffer data does not meet the requirements of the flash driver. Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
serial_flash_fix
branch
from
10d7b79 to
0c1c5f3
Compare
nvlsianpu
requested changes
Dec 5, 2022
That part of the code is unchanged, rem_bytes is set before this code runs, so if it is set then it will run like usual after the main write loop |
nordicjm
added a commit
to nordicjm/sdk-mcuboot
that referenced
this pull request
Dec 6, 2022
Fixes a bug when writing to devices which have memory alignment requirements with data being using directly from a zcbor-response whereby the alignment of the buffer data does not meet the requirements of the flash driver. Upstream PR: mcu-tools/mcuboot#1533 Signed-off-by: Jamie McCrae <[email protected]> (cherry picked from commit 11c5149)
|
@nvlsianpu any comments? |
nvlsianpu
approved these changes
Jan 3, 2023
mbolivar-nordic
pushed a commit
to mbolivar-nordic/sdk-mcuboot
that referenced
this pull request
Feb 20, 2023
Fixes a bug when writing to devices which have memory alignment requirements with data being using directly from a zcbor-response whereby the alignment of the buffer data does not meet the requirements of the flash driver. Upstream PR: mcu-tools/mcuboot#1533 Signed-off-by: Jamie McCrae <[email protected]> (cherry picked from commit 11c5149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when writing to devices which have memory alignment requirements with data being using directly from a zcbor-response whereby the alignment of the buffer data does not meet the requirements of the flash driver.
Fixes #1532