fix pagination annotations#139
Conversation
Picked Open Zaak because VNG ZGW 1.7.0 actually makes none of the attributes on a paged response required... It returns an `Iterable[T | object]` because on the first iteration, the passed in T's will come out, on all following requests, the service responses are only checked if they're valid JSON.
There was a problem hiding this comment.
Not directly related to this PR, but now I'm getting annoyed that #103 has been rotting for so long and I've been rebasing all the time on changes of other people, while now another PR related to type annotations is going to go through so I'll get to do that again.
I don't understand the question. You expect the test to throw a recursion error? |
CharString
force-pushed
the
fix-pagination-annotations
branch
from
ee88697 to
1110037
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 79.83% 79.83%
=======================================
Files 33 33
Lines 1190 1190
Branches 78 78
=======================================
Hits 950 950
Misses 210 210
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CharString
force-pushed
the
fix-pagination-annotations
branch
from
1110037 to
a4cc92b
Compare
No. That's what it does now. I'd expect it to do ~1000 requests. I've rewritten the test for clarity. |
2 participants
Asking if it's a feature or a bug, because I saw the helper being used in a search indexing task...