Skip to content

✨ [#731] Jsonschema format validation#774

Open
danielmursa-dev wants to merge 5 commits into
masterfrom
feature/731-jsonschema-validation
Open

✨ [#731] Jsonschema format validation#774
danielmursa-dev wants to merge 5 commits into
masterfrom
feature/731-jsonschema-validation

Conversation

@danielmursa-dev

Copy link
Copy Markdown
Contributor

Fixes #731

Changes

[Describe the changes here]

Checklist

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how
  • Architectural design record

    • If a design decision was made that changes functionality, create an architectural design record for it here

@danielmursa-dev danielmursa-dev force-pushed the feature/731-jsonschema-validation branch from 63e4f84 to d32e7a1 Compare June 8, 2026 14:27
@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.53086% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.98%. Comparing base (40515e8) to head (3797653).

Files with missing lines Patch % Lines
src/objects/api/utils.py 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   86.77%   86.98%   +0.20%     
==========================================
  Files         145      146       +1     
  Lines        3160     3226      +66     
  Branches      253      258       +5     
==========================================
+ Hits         2742     2806      +64     
- Misses        370      372       +2     
  Partials       48       48              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchfeature/731-jsonschema-validation
Testbedubuntu-24.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type📈 view plot
🚷 view threshold
129.71 ms
(+0.59%)Baseline: 128.96 ms
135.40 ms
(95.80%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result📈 view plot
🚷 view threshold
21.72 ms
(+1.41%)Baseline: 21.42 ms
22.49 ms
(96.58%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1📈 view plot
🚷 view threshold
339.00 ms
(+0.94%)Baseline: 335.86 ms
352.65 ms
(96.13%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5📈 view plot
🚷 view threshold
332.04 ms
(-0.55%)Baseline: 333.87 ms
350.57 ms
(94.71%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20📈 view plot
🚷 view threshold
128.66 ms
(+2.31%)Baseline: 125.76 ms
132.05 ms
(97.43%)
🐰 View full continuous benchmarking report in Bencher

@danielmursa-dev danielmursa-dev force-pushed the feature/731-jsonschema-validation branch 10 times, most recently from cc0bf44 to 56acf0a Compare June 9, 2026 10:31

@stevenbal stevenbal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmursa-dev could you rebase on master to fix the merge conflicts?

@danielmursa-dev danielmursa-dev force-pushed the feature/731-jsonschema-validation branch from 56acf0a to 04ccf47 Compare June 16, 2026 12:52
@danielmursa-dev danielmursa-dev marked this pull request as draft June 16, 2026 12:55
@danielmursa-dev danielmursa-dev force-pushed the feature/731-jsonschema-validation branch from 04ccf47 to 0865449 Compare June 18, 2026 07:53
@danielmursa-dev danielmursa-dev marked this pull request as ready for review June 18, 2026 08:41
@danielmursa-dev

Copy link
Copy Markdown
Contributor Author

@danielmursa-dev could you rebase on master to fix the merge conflicts?

@stevenbal Done

@danielmursa-dev danielmursa-dev force-pushed the feature/731-jsonschema-validation branch from a08486e to 3797653 Compare June 19, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schema should validate custom format attributes & update data_attrs filter

3 participants